Skip to content

fix(web): clarify archived channels and integration secrets - #330

Merged
steipete merged 6 commits into
openclaw:mainfrom
KrasimirKralev:fix/archived-channel-composer
Nov 21, 2026
Merged

steipete merged 6 commits into
openclaw:mainfrom
KrasimirKralev:fix/archived-channel-composer

Conversation

@KrasimirKralev

@KrasimirKralev KrasimirKralev commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

What Problem This Solves

Archived channels offer composers even though the server rejects new posts and replies. Rotated integration secrets also appear in text fields with no accessible name.

User Impact

Channel and thread composers now explain that the channel is archived and how to continue, including embedded views. Restoring the channel re-enables them. Screen readers can identify the one-time signing-secret fields for slash commands and event subscriptions.

Why This Change Was Made

The web app now observes the server's existing archive rule, including realtime restore events. Each revealed secret is associated with its own row's label. This includes the verified fix from #333, with credit to @KrasimirKralev for both fixes.

The maintenance refresh updates eligible web, desktop, and development dependencies after the 48-hour cooldown. It preserves the Node and Go floors, security overrides, SQLite/libc pairing, Virtua scroll-restoration pin, and the protocol generator's TypeScript 5 compiler. No manual deployment is part of this PR.

Evidence

The three regression checks fail on unchanged main: main and embedded archived composers are still enabled, and the revealed secret has no accessible name. Independent P0–P2 review of each original fix is clean. The final combined checks pass: all 19 affected Playwright tests, web utilities and Go package tests, FakeCo and desktop tests, typechecks, lint/format, docs build, and Go vulnerability scan. The one Go fixture failure under a restrictive umask was fixed and the exact test passed on rerun. The embedded app builds repeatably and the tested source hashes match the reviewed files.

Contributor screenshots inspected: synthetic workspace and messages only.

Before: archived channel accepts input and reports a failed send

After: archived composer is disabled with recovery advice

The signing-secret change affects accessibility names without a visual change; the browser checks assert each name and its own row's value without publishing any secret values.

@KrasimirKralev
KrasimirKralev requested a review from a team as a code owner November 15, 2026 07:29
@clawsweeper

clawsweeper Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper clawsweeper Bot added clawsweeper:intake:bug Preliminary submission classification; full source review pending. P2 Normal priority bug or improvement with limited blast radius. proof: sufficient Contributor real behavior proof is sufficient. proof: 📸 screenshot Contributor real behavior proof includes screenshot evidence. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed clawsweeper:intake:bug Preliminary submission classification; full source review pending. labels Nov 15, 2026
@clawsweeper

clawsweeper Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Codex review: needs maintainer review before merge.

What this changes

Disable archived-channel message and reply composers across chat and embeds, explain recovery, and re-enable them after restoration.

Example: A user opens archived #general and tries to send “Can anyone see this?”.

  • Before: The composer accepts input, then sending fails with a generic retry message.
  • After: The composer is disabled and explains that the user can choose an active channel or ask an owner to restore it.

Review scores

Measure Result What it means
Overall readiness 🦞 diamond lobster (5/6) Focused contract alignment with shipped-entry-point evidence, meaningful browser regressions, and no identified actionable defect.
Proof confidence 🦞 diamond lobster (5/6) ✨ media proof bonus Sufficient (screenshot): Inspected screenshots show the changed chat and embedded-channel composers against the real Go server in Chromium; supplied terminal output additionally shows the embedded-thread archive notice and re-enabling after API restoration without navigation.
Patch quality 🦞 diamond lobster (5/6) No actionable review findings were identified.

Product

Kind: Bug fix · Worth it: Yes · Fix scope: Complete
User problem: Archived channels invite users to compose messages that always fail with generic retry advice.
Reason: The frontend should reflect the already shipped server restriction and explain the available recovery paths.

Merge readiness

✅ Ready for maintainer review

Keep open: this PR fixes a current mismatch between the web composers and the server’s archived-channel contract; no blocking defect was found.

Priority: P2
Reviewed head: fc621b8405a4bd4f8f1560e44ef085d3af7cf9e9

Before merge

None.

Findings

None.

Agent review details

How this fits together

Channel metadata and realtime updates feed the web chat and embedded views, which derive composer availability before submitting messages to the existing API.

flowchart TD
ChannelMetadata --> ChatApp
ChannelMetadata --> EmbeddedViews
RealtimeUpdates --> ChatApp
RealtimeUpdates --> EmbeddedViews
ChatApp --> SharedComposers
EmbeddedViews --> SharedComposers
SharedComposers --> PostingAPI
Loading

Technical review

Best possible solution:

Land the focused frontend alignment with the existing archive contract and retained realtime restoration behavior.

Do we have a high-confidence way to reproduce the issue?

Current-main source exposes enabled archived-channel composers despite server rejection, and the contributor supplies matching before/after browser evidence; no target code was run during this review.

Is this the best way to solve the issue?

The patch uses existing channel metadata, realtime refresh, and shared composer controls without changing API permissions, stored state, or archive semantics.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 38d16cff5204.

Provenance checked

Testing

Proof path: shipped entry point.

Security

None.

Evidence

What I checked:

Preflight source

Source unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified.

Review metrics

Metric Value Why it matters
Handwritten change size Production +51/-13 lines; browser tests +66/-0 lines The growth covers the existing chat and embed surfaces plus archive/restore regression coverage; generated assets are excluded.

Labels

Label changes:

No label changes.

Label justifications:

  • P2: This fixes a limited archived-channel workflow where enabled composers invite submissions the server rejects.
  • rating: 🦞 diamond lobster: Overall readiness is 🦞 diamond lobster; proof is 🦞 diamond lobster and patch quality is 🦞 diamond lobster.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.
  • proof: sufficient: Contributor real behavior proof is sufficient.
  • proof: 📸 screenshot: Contributor real behavior proof includes screenshot evidence.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

History

Review history (4 earlier review cycles)
  • reviewed 2026-11-15T07:43:18.854Z sha b30a39b :: needs maintainer review before merge. :: [P3] Add a recovery action to the archived-channel notice
  • reviewed 2026-11-15T07:51:29.056Z sha 91e5a1b :: needs maintainer review before merge. :: none
  • reviewed 2026-11-15T08:06:04.821Z sha 1764b26 :: needs real behavior proof before merge. :: [P2] Refresh embedded-thread archive state after channel updates
  • reviewed 2026-11-15T08:20:09.395Z sha eb693fb :: needs maintainer review before merge. :: none

Reviewed November 19, 2026, 2:19 AM ET / 07:19 UTC (Revision 5).

@KrasimirKralev

Copy link
Copy Markdown
Contributor Author

@clawsweeper re-review

@clawsweeper

clawsweeper Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

🦞👀
Exact review queued.

Re-review progress:

@clawsweeper clawsweeper Bot added clawsweeper:intake:bug Preliminary submission classification; full source review pending. clawsweeper:intake:needs-environment Preliminary submission classification; full source review pending. and removed clawsweeper:intake:bug Preliminary submission classification; full source review pending. clawsweeper:intake:needs-environment Preliminary submission classification; full source review pending. labels Nov 15, 2026
@KrasimirKralev

Copy link
Copy Markdown
Contributor Author

@clawsweeper re-review

@clawsweeper

clawsweeper Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

🦞👀
Exact review queued.

Re-review progress:

@clawsweeper clawsweeper Bot added clawsweeper:intake:bug Preliminary submission classification; full source review pending. rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. and removed rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. proof: sufficient Contributor real behavior proof is sufficient. clawsweeper:intake:bug Preliminary submission classification; full source review pending. labels Nov 15, 2026
@KrasimirKralev

Copy link
Copy Markdown
Contributor Author

@clawsweeper re-review

@clawsweeper

clawsweeper Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

🦞👀
Exact review queued.

Re-review progress:

@clawsweeper clawsweeper Bot added clawsweeper:intake:bug Preliminary submission classification; full source review pending. and removed status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. labels Nov 15, 2026
@clawsweeper clawsweeper Bot added proof: sufficient Contributor real behavior proof is sufficient. rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed clawsweeper:intake:bug Preliminary submission classification; full source review pending. labels Nov 15, 2026
@KrasimirKralev
KrasimirKralev force-pushed the fix/archived-channel-composer branch from eb693fb to fc621b8 Compare November 19, 2026 07:13
@KrasimirKralev

Copy link
Copy Markdown
Contributor Author

@clawsweeper re-review

@clawsweeper

clawsweeper Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

🦞👀
Exact review queued.

Re-review progress:

Refresh compatible dependencies and make the file-mode preservation fixture independent of the process umask.

Co-authored-by: Krasimir Kralev <263465593+KrasimirKralev@users.noreply.github.com>
@steipete steipete changed the title fix(web): disable composers in archived channels fix(web): clarify archived channels and integration secrets Nov 21, 2026
@steipete
steipete merged commit 8e42adb into openclaw:main Nov 21, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P2 Normal priority bug or improvement with limited blast radius. proof: 📸 screenshot Contributor real behavior proof includes screenshot evidence. proof: sufficient Contributor real behavior proof is sufficient. rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants